[gmx-developers] Bug in trnio.c ?

[Campbell Millar]

Hi Folks,

I have been modifying some bespoke brownian dynamics code to generate 
gromacs trajectories and have run into some problems with the trn 
header code when reading trajectories.

In do_trnheader (line 110 of trnio.c ) the float precision is 
calculated using sh->natoms. However, in the gromacs-3.2.1 source, 
natoms is not read until after the precision check which causes errors 
from gmxcheck and gmxdump due to the fact that sh->numatoms is 
uninitialised.

Simple fix is to move line 115 ( *bOK=*bOK && do_int( sh->natoms ); ) 
to line 105 following the force vector read.

Cheers,

Campbell
__________________________
Dr Campbell Millar,
University of Glasgow,
Device Modelling Group,
Oakfield Avenue,
Glasgow G12 8LT
tel: +44 141 330 4792  fax: +44 141 330 4907

"Diplomacy is the art of saying 'nice doggy', till you can find a rock"
Larry Niven.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2375 bytes
Desc: not available
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20040701/cf8e3a3f/attachment.p7s>