[gmx-developers] bad sed expression in share/template/Makefile.am

[Mark Abraham]

Ake Sandgren wrote:
> Hi!
> 
> The sed in share/template/Makefile.am uses "," as separator. This is bad
> since LDFLAGS and others might contains things like -Wl,-rpath and other
> things with "," in them. "#" is usually a better choice.

Using "," as a sed separator seems to be standard practice with the 
autotools. From autoconf docs:

"When using sed, don't use -e except for indenting purpose. With the s 
command, the preferred separator is `/' unless `/' itself is used in the 
command, in which case you should use `,'. "

Wouldn't "#" get interpreted as a Makefile comment?

Mark