[gmx-developers] Typo in pdbio.h

[Sébastien Buchoux]

Hi,

While playing around with interfacing Python and gmxlib, I discovered a 
typo in pdbio.h on line 139:
function declaration should be "gmx_conect gmx_conect_init(void);" 
instead of "gmx_conect gmx_conect_init();"
This is far from harmful but gcc doesn't like it and complains about it 
when compiling my Python C extensions (at least until I modified the 
header file). This is hidden when using the CMake machinery though.
This typo is present in pdbio.h provided with GROMACS 4.5.3, 4.5.4 and 
is still present in pdbio.h from the master branch.

By the way, when I checked the "dev version" of pdbio.h on redmine, I 
discovered that the classical "include" folder was no longer present and 
that header files were now either with source files or in the 
"legacyheaders" directory. Are there some big changes in the GROMACS 
source files architecture going on?

Cheers,

Sébastien

-- 
Sébastien Buchoux, Ph.D
UMR 6022 - Génie Enzymatique et Cellulaire / Enzyme and Cell Engineering
Université Picardie Jules Verne (UPJV)
33, rue Saint Leu, 80000 Amiens, France
tel: +33(0)3 22 82 74 73 - email: sebastien.buchoux[at]u-picardie.fr