[gmx-developers] Typo in pdbio.h

[David van der Spoel]

On 2011-04-06 18.14, David van der Spoel wrote:
> On 2011-04-06 17.54, Sébastien Buchoux wrote:
>> Hi,
>>
>> While playing around with interfacing Python and gmxlib, I discovered a
>> typo in pdbio.h on line 139:
>> function declaration should be "gmx_conect gmx_conect_init(void);"
>> instead of "gmx_conect gmx_conect_init();"
>> This is far from harmful but gcc doesn't like it and complains about it
>> when compiling my Python C extensions (at least until I modified the
>> header file). This is hidden when using the CMake machinery though.
>> This typo is present in pdbio.h provided with GROMACS 4.5.3, 4.5.4 and
>> is still present in pdbio.h from the master branch.
> Will fix it.
Done.

>>
>> By the way, when I checked the "dev version" of pdbio.h on redmine, I
>> discovered that the classical "include" folder was no longer present and
>> that header files were now either with source files or in the
>> "legacyheaders" directory. Are there some big changes in the GROMACS
>> source files architecture going on?
> No, HUGE.
>
>>
>> Cheers,
>>
>> Sébastien
>>
>
>


-- 
David van der Spoel, Ph.D., Professor of Biology
Dept. of Cell & Molec. Biol., Uppsala University.
Box 596, 75124 Uppsala, Sweden. Phone:	+46184714205.
spoel at xray.bmc.uu.se    http://folding.bmc.uu.se