[gmx-developers] Assorted patch submission questions

[Roland Schulz]

2012/2/10 Tomáš Trnka <ttrnka at mail.muni.cz>

> Hello all GMX devs,
>
> I've implemented the ASPC method for polarizable molecular dynamics
> (KOLAFA,
> J.; J. Comput. Chem. 2004, 25, 335-342) for GROMACS and would love to see
> this
> included in mainline.
>
> A simple benchmark with 216 SWM4-NDP water molecules shows that using ASPC
> the
> simulation is six times faster with energy drift reduced about fourfold
> compared to the steepest descent minimization.
>


However, I've never used gerrit before and therefore would like to ask some
> questions first instead of going ahead blindly and making a mess:
>
> 1) Is there any way to submit a patch series for review or do I have to
> squash
> it all into a single patch? (the GROMACS website keeps talking about a
> single
> commit everywhere in the Gerrit introduction AFAICS)
>
Depends on the size of your commit (<1000 lines it is OK to have 1 commit -
above it might be nicer to have more but not mandatory) and whether you can
split it into more than one logical commit (each logical commit should add
a new feature (or prepare something) and should be working correctly by
itself). You don't want to commit the originally history with all the
little fixup commits.

>
> 2) Most of my changes are in the shellfc.c file and the coding style there
> doesn't match the guidelines at all (indent is two spaces, ifs/fors have
> braces on the same line) - shall I go for compliance with guidelines or
> consistency with the existing code?
>
Either way is OK as long as it is somewhat consistent within your change.
We will be fixing the formatting soon: http://redmine.gromacs.org/issues/845

Roland


>
> Thanks for your time answering this.
> Best regards
>
> Tomáš Trnka
> --
> Laboratory of Computational Chemistry
> National Centre for Biomolecular Research, Masaryk University
> Brno, Czech Republic
> --
> gmx-developers mailing list
> gmx-developers at gromacs.org
> http://lists.gromacs.org/mailman/listinfo/gmx-developers
> Please don't post (un)subscribe requests to the list. Use the
> www interface or send it to gmx-developers-request at gromacs.org.
>
>
>
>
>


-- 
ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
865-241-1537, ORNL PO BOX 2008 MS6309
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20120210/b53550a1/attachment.html>