[gmx-developers] jenkins cppcheck picky?

[Erik Lindahl]

Hi,

That "bad" glibc version is probably still around on some platforms, so it seems like a better idea to just add a field limit?

Although I have no idea what file you are reading here, file I/O is a big culprit where we are usually not checking the input carefully enough!

Cheers,

Erik


On Aug 31, 2013, at 9:33 PM, David van der Spoel <spoel at xray.bmc.uu.se> wrote:

> Hi,
> 
> I'm getting complaints in jenkins from cppcheck, for code like
> 
> int d;
> fscanf(fp, "%d", &d);
> 
> namely:
> 
> scanf without field width limits can crash with huge input data
> 
> Apparently this is a check for an old glibc or something:
> http://sourceforge.net/apps/trac/cppcheck/ticket/3946
> 
> Can we upgrade cppcheck?
> 
> -- 
> David van der Spoel, Ph.D., Professor of Biology
> Dept. of Cell & Molec. Biol., Uppsala University.
> Box 596, 75124 Uppsala, Sweden. Phone:	+46184714205.
> spoel at xray.bmc.uu.se    http://folding.bmc.uu.se
> -- 
> gmx-developers mailing list
> gmx-developers at gromacs.org
> http://lists.gromacs.org/mailman/listinfo/gmx-developers
> Please don't post (un)subscribe requests to the list. Use the www interface or send it to gmx-developers-request at gromacs.org.