[gmx-developers] 4.6.1 is out

Mark Abraham mark.j.abraham at gmail.com
Fri Mar 8 15:12:45 CET 2013

On Wed, Mar 6, 2013 at 2:40 PM, Shirts, Michael (mrs5pt) <
mrs5pt at eservices.virginia.edu> wrote:

> > Code reviewing can be sped up by adding reviewers. The person that
> > submits a gerrit patch usually has a decent idea of who might know the
> > code sufficiently well to review it. We should however share the load
> > and not dump everything on e.g. Berk. I usually add two to three people
> > to patches, which means they get mail at least once.
> This is something I struggle with -- I don't always know who to add.  Berk
> knows integrators and free energy, Sander knows free energies . . . And I
> don't know who else.
> So if we had some sort of list of who could review on what subject, that
> might be good.

Sounds good to me. I'd suggest we'd need some kind of table where people
have a name, a list of topics they're interested to review, and a list of
topics they know they can't/won't review. Ideally, Gerrit would present a
link to that page so that people can browse it when they have added a new
patch. Not sure how feasible that is. Wanting anybody to be able to edit
their own information makes it feel more like wiki content than Redmine
content to me, so I'd suggest a new subsection of
http://www.gromacs.org/Developer_Zone/Git/Gerrit. Any further thoughts?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20130308/05dc591b/attachment.html>

More information about the gromacs.org_gmx-developers mailing list