[gmx-developers] bug in uncrustify

Berk Hess hess at kth.se
Wed Dec 3 10:13:46 CET 2014


Hi,

I just fixed a formatting issue in domdec.cpp:
           if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac <  limit ||
!             (comm->cell_f0[d] - comm->cell_f_min1[d])*bfac > -limit)

           if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac <  limit ||
! (comm->cell_f0[d]

I was already wondering why uncrustify on Jenkins didn't complain about 
the formatting, but I now found out that that's because uncrustify 
generates the incorrect formatting. Is this a known bug? What should I 
do with my patch, format it incorrectly on purpose?

Cheers,

Berk



More information about the gromacs.org_gmx-developers mailing list