[gmx-developers] bug in uncrustify

[Berk Hess]

Hi,

I fixed the formatting of line 2491 of src/gromacs/domdec/domdec.cpp in:
https://gerrit.gromacs.org/#/c/4192/31

I am running the latest release of uncrustify: version 0.60.

Cheers,

Berk

On 12/03/2014 10:24 AM, Roland Schulz wrote:
> Hi,
>
> which patch and what line number? We could check whether it is fixed 
> in the git master version of uncrustify.
>
> Roland
>
> On Wed, Dec 3, 2014 at 4:14 AM, Berk Hess <hess at kth.se 
> <mailto:hess at kth.se>> wrote:
>
>     Hi,
>
>     I just fixed a formatting issue in domdec.cpp:
>                if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac < 
>     limit ||
>     !             (comm->cell_f0[d] - comm->cell_f_min1[d])*bfac > -limit)
>
>                if ((comm->cell_f1[d] - comm->cell_f_max0[d])*bfac < 
>     limit ||
>     ! (comm->cell_f0[d]
>
>     I was already wondering why uncrustify on Jenkins didn't complain
>     about
>     the formatting, but I now found out that that's because uncrustify
>     generates the incorrect formatting. Is this a known bug? What should I
>     do with my patch, format it incorrectly on purpose?
>
>     Cheers,
>
>     Berk
>
>     --
>     Gromacs Developers mailing list
>
>     * Please search the archive at
>     http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List
>     before posting!
>
>     * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>
>     * For (un)subscribe requests visit
>     https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
>     or send a mail to gmx-developers-request at gromacs.org
>     <mailto:gmx-developers-request at gromacs.org>.
>
>
>
>
> -- 
> ORNL/UT Center for Molecular Biophysics cmb.ornl.gov <http://cmb.ornl.gov>
> 865-241-1537, ORNL PO BOX 2008 MS6309
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20141203/92162327/attachment-0001.html>