[gmx-developers] Minor bug in ewald.c:init_ewald_tab

[Rui Fartaria]

Hi all,

I could not find this as reported yet so, here it goes:

init_ewald_tab allocates space (snew(*et, 1);) for the *et memory reference
that is passed to it.

In all places I saw it being called the reference passed is not of a
pointer but always of a normal variable.

Anyway, I think the correct procedure here would be for the caller to
allocate space and then call init_ewald_tab. This is because the function
does not know what is being passed to it.

Kind regards,

Rui Fartaria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20140515/d2b60981/attachment.html>