[gmx-developers] future of tabulated bonded interactions

Teemu Murtola teemu.murtola at gmail.com
Wed Jun 1 19:27:49 CEST 2016


On Wed, Jun 1, 2016 at 1:06 PM Mark Abraham <mark.j.abraham at gmail.com>

> So I've fixed them, and after two months Teemu found time to look at the
> straightforward fix + tests. After a further month, nobody else has had
> time to look. Meanwhile, it isn't worth me continuing development to
> support such a feature until I see that somebody cares about it.

I agree that the delay in getting things reviewed is sometimes very long.
But the above is a bit one-sided. It is true that it took me two months to
find time to review stuff (because of various reasons, including other
Gromacs work and general lack of free time), and there's not much more to
say about that. But once I did provide comments, the next month the patch
just sat there in Gerrit, waiting for some of my comments to be addressed.
It might very well be that no one else looked at it, but if I had not been
the one to post comments and had looked at it, I would have just ignored it
because there were still unaddressed comments from someone else. After the
findings were addressed, it took all of a four days to get it merged.

The responsiveness in reviewing stuff goes both ways. I have currently some
75 changes in the "incoming reviews" category, which is something like 50%
of all open changes in Gerrit! And quite a few of those are really old,
where either the change doesn't even pass Jenkins, where there have been
comments from reviewers and then no action whatsoever afterwards, or that
has been long since been obsoleted by some other change. This is a huge
demotivating factor for reviewing stuff, not to mention that it is a waste
of time scanning through the same list over and over again to see whether
there would be a change somewhere in that 50+ changes (or in the 150+ open
changes) that could be usefully reviewed...

Best regards,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20160601/db0f04bf/attachment.html>

More information about the gromacs.org_gmx-developers mailing list