[gmx-developers] Code Browser (dev call follow up)

Mark Abraham mark.j.abraham at gmail.com
Wed Feb 1 14:27:06 CET 2017


It could help a bit, particularly with giving people more ability to feel
confident in reviewing the code without having to do a full checkout.
However, if the patch under review changes aspects of the API, how does
that work? Relying on a nightly build for the infrastructure behind the
click-to-jump-to-definition seems like it might have too much friction.

People with less experience of the code base than me should particularly
speak up here. :-) You're the market where this has a large impact.


On Wed, Feb 1, 2017 at 1:58 AM Schulz, Roland <roland.schulz at intel.com>

> Hi,
> As I mentioned on the last developer call, there is a code browser and
> Gerrit integration available. One can click on a function in Gerrit to go
> the definition and usages. It is available in the QT Gerrit and it looks
> like http://imgur.com/Q3a2ixz . The links go to
> https://code.woboq.org/qt5/qtbase/src/corelib/io/qurl.cpp.html#_ZN4QUrl13fromLocalFileERK7QString
> and
> https://code.woboq.org/data/symbol.html?root=../qt5/&ref=_ZN4QUrl13fromLocalFileERK7QString#uses
> It can be tried out on https://codereview.qt-project.org after installing
> https://code.woboq.org/qt-gerrit.user.js which requires Greasmonkey for
> Firefox / Tampermonkey for Chrome. A bit more detail about the integration
> is at
> http://lists.qt-project.org/pipermail/development/2016-May/025733.html
> and the about the code browser at https://woboq.com/codebrowser.html .
> Do you think this would help with productivity in code review making it
> worth taking the time installing it? The installation instructions are at
> https://github.com/woboq/woboq_codebrowser/blob/master/README.md
> Roland
> --
> Gromacs Developers mailing list
> * Please search the archive at
> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
> posting!
> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
> * For (un)subscribe requests visit
> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
> or send a mail to gmx-developers-request at gromacs.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20170201/8784a6b3/attachment.html>

More information about the gromacs.org_gmx-developers mailing list