[gmx-developers] gerrit changing the way drafts are supported

[Schulz, Roland]

Quoting from the changes:

The draft change feature has been removed, and replaced with two separate features:

  *   Private changes<https://gerrit-documentation.storage.googleapis.com/Documentation/2.15/intro-user.html#private-changes> are visible only to the owner and reviewers.
  *   Work-in-progress changes<https://gerrit-documentation.storage.googleapis.com/Documentation/2.15/intro-user.html#wip> do not generate notifications.

After we have finished the upgrade the project owner can change the state of the a change from private to WIP (or reverse) (and of course also to/from public). The main question is whether we want the draft changes to be migrated to private or WIP as part of the upgrade. I suspect that most of us use draft more like private rather than WIP (given that we use WIP in the message for WIP). Thus I think it makes sense to migrate draft to private. Does everyone agree or does anyone prefer draft to migrated to WIP? Migrating to WIP is the default, but the migration script lets one choose either option.

Roland

From: gromacs.org_gmx-developers-bounces at maillist.sys.kth.se [mailto:gromacs.org_gmx-developers-bounces at maillist.sys.kth.se] On Behalf Of Mark Abraham
Sent: Monday, August 27, 2018 1:36 AM
To: gmx-developers at gromacs.org
Cc: gromacs.org_gmx-developers at maillist.sys.kth.se
Subject: Re: [gmx-developers] gerrit changing the way drafts are supported

Hi,

Note that our use of [WIP] in commit messages is a different thing from the change in the new gerrit. Uploading to gerrit still works the same way - default is public, but you'll be able to mark it WIP to control when your work is presented to others.

Mark

On Mon, Aug 27, 2018 at 10:32 AM Paul Bauer <paul.bauer.q at gmail.com<mailto:paul.bauer.q at gmail.com>> wrote:

Hej,

I saw that as well and I'm in general fine with it, as I anyhow flag my changes as WIP if I have them in draft stage. I have to read up on it a bit more but I think changes should be moved to WIP status by default, and if individual devs want to move them to private later that should work.

Cheers

Paul

On 2018-08-27 10:25, Mark Abraham wrote:
Hi,

We'll probably upgrade gerrit to 2.15 shortly, and Stefan noted that it will change the way drafts are organized. Instead of an individual patch set being a draft, the whole change is flagged work in progress within the Gerrit metadata. I think that, and the automated change of stuff on upgrades will be fine for us, but I thought I would flag that for those of you who use drafts. In principle, code could change its visibility through the migration process. I can't see all of the drafts, so I don't know who you all are ;-)

Info: https://www.gerritcodereview.com/2.15.html#support-for-draft-changes-removed

Mark


--
Gromacs Developers mailing list

* Please search the archive at http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before posting!

* Can't post? Read http://www.gromacs.org/Support/Mailing_Lists

* For (un)subscribe requests visit
https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers or send a mail to gmx-developers-request at gromacs.org<mailto:gmx-developers-request at gromacs.org>.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20180827/aa091363/attachment-0003.html>