[gmx-developers] FindFFTW checking for r2r_1d call that's not used?

[Christoph Junghans]

On Tue, Sep 11, 2018 at 08:19 Szilárd Páll <pall.szilard at gmail.com> wrote:

> Hi,
>
> I did (the source is f822304), so hoping Christoph or someone else recalls
> if this is a choice we made with a reason that's still valid nad should be
> considered.
>
Yeah, there is nothing special about that function! It just happened to be
a function, I knew, would exist in the fftw library.

Christoph

>
> --
> Szilárd
>
>
> On Tue, Sep 11, 2018 at 4:02 PM Mark Abraham <mark.j.abraham at gmail.com>
> wrote:
>
>> Hi,
>>
>> I would check git blame, and the gerrit / Redmine discussion for that
>> change, and if nothing comes to light, assume that someone just picked a
>> plausible function, thus we can change that choice.
>>
>> Mark
>>
>> On Tue, Sep 11, 2018 at 3:42 PM Szilárd Páll <pall.szilard at gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> I was wondering if somebody can explain why is cmake/FindFFTW.cmake
>>> checking for fftw[f]_plan_r2r_1d instead of checking the actual API calls
>>> we use? I assume this must be a proxy for something else, but not sure
>>> what. This has come up while trying to integrate ARMPL which does not
>>> implement r2r, but does implement the many_dft_c2r/r2c that we do use.
>>>
>>> Any objections against checking the functions that we do actually use?
>>>
>>> Cheers,
>>> --
>>> Szilárd
>>> --
>>> Gromacs Developers mailing list
>>>
>>> * Please search the archive at
>>> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
>>> posting!
>>>
>>> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>>>
>>> * For (un)subscribe requests visit
>>> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
>>> or send a mail to gmx-developers-request at gromacs.org.
>>
>> --
>> Gromacs Developers mailing list
>>
>> * Please search the archive at
>> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
>> posting!
>>
>> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>>
>> * For (un)subscribe requests visit
>> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
>> or send a mail to gmx-developers-request at gromacs.org.
>
> --
> Gromacs Developers mailing list
>
> * Please search the archive at
> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
> posting!
>
> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>
> * For (un)subscribe requests visit
> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
> or send a mail to gmx-developers-request at gromacs.org.

-- 
Christoph Junghans
Web: http://www.compphys.de
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20180911/829eb4fe/attachment.html>