[gmx-developers] -Wextra-semi

[Mark Abraham]

Hi,

Ah, I see that that warning is also in at least clang 6, and that's only
used in the clang_cuda post-submit. There's probably not enough value in
converting a pre-submit config with clang to build with CUDA support (even
though e.g. CUDA 9.2 supports clang 5 natively), but if we just suppress
the warning, then we'll handle the issue in advance of when a CUDA version
supports gcc 8 (which we would test in pre-submit). Or we could add OpenCL
support to the asan or tsan build with clang-7, which is a stone that might
kill other birds...

Mark

On Tue, 5 Mar 2019 at 13:43 Mark Abraham <mark.j.abraham at gmail.com> wrote:

> Hi,
>
> That behaviour was added to -Wall in gcc 8. I agree that's something we
> don't need to warn about. We can change cmake/CFlags.cmake to add
> -Wno-extra-semi to suppress it.
>
> Mark
>
> On Tue, 5 Mar 2019 at 12:01 Berk Hess <hess at kth.se> wrote:
>
>> Hi,
>>
>> A post submit build uses -Wextra-semi which gives warnings that other
>> builds don't give. If I understood corretly this warns for someting that
>> is allowed in C++11. Should we remove this flag?
>>
>> Cheers,
>>
>> Berk
>>
>> --
>> Gromacs Developers mailing list
>>
>> * Please search the archive at
>> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
>> posting!
>>
>> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>>
>> * For (un)subscribe requests visit
>> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
>> or send a mail to gmx-developers-request at gromacs.org.
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20190305/5f32ea8f/attachment.html>