[gmx-developers] Questions for clean Gerrit submissions

Eric Irrgang ericirrgang at gmail.com
Sat Apr 1 00:32:06 CEST 2017


Hi folks,

I have a few questions about how to post prettier code submissions to
Gerrit. I hope you can help.

 * can/should Gerrit and Jenkins handle git submodules
   and be configured to `git pull --recurse-submodules`
   so that we don't have to include potentially useful supporting
   libraries in draft commits?

 * Is there a Gromacs convention for dealing with unused
   parameters in polymorphic methods to avoid compiler warnings
   and potential waste?

 * is there a way to keep uncrustify from wanting to mangle brace
    construction in constructor initializer lists? e.g. uncrustify wants
    to do this:
MyClass() :
    a_ {nullptr},
b_ {},
c_ {
    &b_
},
...

Thank you for any enlightenment you can provide!
Eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20170331/d060a970/attachment.html>


More information about the gromacs.org_gmx-developers mailing list