[gmx-developers] gerrit guide

Tue Jul 31 12:55:23 CEST 2018

Hi,

As someone who just recently started, I agree that porting the info on
getting started with gerrit is worth it - I found the webpage quite
helpful, but I wasn’t sure if it was up-to-date, so I was hesitant to try
out the commands in the instructions.

I also agree with Joe’s comment on uncrustify. The "Automatic Source
Control" section could benefit from an example of how to use uncrustify
manually (particularly in reference to a configuration file), and maybe a
little clarification on configuring it to run automatically.

I'd like to throw in that it might be useful (particularly for someone like
me who hasn't really contributed to open source projects in the past) to
include an overview of the development process, such as is found here:
http://www.gromacs.org/Developer_Zone/Developer_Workflow

I'd be happy to port those pages to the manual if others agree!

Kevin

On Jul 31, 2018, at 4:31 AM, Joe Jordan <e.jjordan12 at gmail.com> wrote:

My two cents would be that it would be better to port than link. The feel
of the gerrit page is very 2004. Additionally it could benefit from having
the example code snippets code highlighted in the currently standard code
boxes. I personally had a hard time when I was starting developing figuring
out how to work with gerrit and uncrustify, so I think these sections could
also use some copy editing that I would be happy to contribute to.

As a constructive example,

git clone ssh://*USER*@gerrit.gromacs.org/gromacs.git
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234542281&sdata=SMBvc%2F0LmUyQF3Yg24Vxl4Dh20rs5TWMXxYLJsi4TLI%3D&reserved=0>

git remote set-url origin ssh://*USER*@gerrit.gromacs.org/gromacs.git
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234542281&sdata=SMBvc%2F0LmUyQF3Yg24Vxl4Dh20rs5TWMXxYLJsi4TLI%3D&reserved=0>

git remote add upload ssh://*USER*@gerrit.gromacs.org/gromacs.git
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgerrit.gromacs.org%2Fgromacs.git&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234552291&sdata=t4uHho3t2IYkkf0SMhVVsnC3hY0VkE6hZedyyYZPC2I%3D&reserved=0>

scp -p *USER*@gerrit.gromacs.org:hooks/commit-msg .git/hooks/

could be one (line numbered) code block with text explaining each line.
This way users could copy it directly into a script to run whenever the
want to fetch a new gromacs source instance.

As for uncrustify, it would be helpful both to mention that uncrustify is a
script in the admin folder that you can run, since I (and one other newbie
I talked to) had a hard time figuring this out. It could also be good to
have a code listing and explanation of the actual uncrustify command that
gerrit runs, in addition to a code listing for how to fix uncrustify errors
using reformat_all (which is currently lacking).

On Mon, Jul 30, 2018 at 7:10 PM, Eric Irrgang <ericirrgang at gmail.com> wrote:

> Hi All,
>
> I would like to either port
> http://www.gromacs.org/Developer_Zone/Git/Gerrit
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FDeveloper_Zone%2FGit%2FGerrit&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234552291&sdata=GzhreisGhqHM1WD%2FFwJSPpDPVXEg0jkTwIkR1%2FB9vFc%3D&reserved=0>
> or link to it from
> the (new) "Contributing" section of the Developer Guide.
>
> I remember some discussion about the sorts of documentation that
> should live in the repository versus somewhere else, and I think the
> upshot was that things like advice on using Gerrit don't belong in the
> primary repository, but I could be misremembering because
> Understanding Jenkins Builds is in there.
>
> So my thought is to at least link to the old content in
> Developer_Guide/Developmen-time_tools/Change_management and in
> Developer_Guide/Contribute_to_GROMACS
>
> My question is whether to link to the old content or port that page to
> the new dev-manual. Thoughts?
>
> Thanks,
> Eric
> --
> Gromacs Developers mailing list
>
> * Please search the archive at http://www.gromacs.org/Support
> /Mailing_Lists/GMX-developers_List
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists%2FGMX-developers_List&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234562296&sdata=pZ26sC2tbhsDr03gPP3laAM7Q%2FBQB5lF5I7DxyehmWM%3D&reserved=0>
> before posting!
>
> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234562296&sdata=a2hl%2F6OnVawo5nRTXRjrUC5LYj6ywydZvKW0p1xYEPM%3D&reserved=0>
>
> * For (un)subscribe requests visit
> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmaillist.sys.kth.se%2Fmailman%2Flistinfo%2Fgromacs.org_gmx-developers&data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234572300&sdata=WdFefbk7rqPi68SW2E2Onu9oU7ow2RozrF6DM8Dj%2BW8%3D&reserved=0>
> or send a mail to gmx-developers-request at gromacs.org.
>

-- 
Joe Jordan

-- 
Gromacs Developers mailing list

* Please search the archive at https://na01.safelinks.
protection.outlook.com/?url=http%3A%2F%2Fwww.gromacs.org%
2FSupport%2FMailing_Lists%2FGMX-developers_List&amp;
data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%
7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;
sdata=2xbrVYyZ%2FDdA8oyqvQmQ9Ic1mI%2FPIPxsmWd96i6HljU%3D&amp;reserved=0
before posting!

* Can't post? Read https://na01.safelinks.protection.outlook.com/?url=
http%3A%2F%2Fwww.gromacs.org%2FSupport%2FMailing_Lists&amp;
data=02%7C01%7Ckevin.boyd%40uconn.edu%7C284e0eef573d4fbbbe3208d5f6c01641%
7C17f1a87e2a254eaab9df9d439034b080%7C0%7C1%7C636686227234582310&amp;sdata=
X30gtkdD0u3MXr0M2fly5f9FQzekTy0uO1Vt8kPJjgE%3D&amp;reserved=0

* For (un)subscribe requests visit
https://na01.safelinks.protection.outlook.com/?url=
https%3A%2F%2Fmaillist.sys.kth.se%2Fmailman%2Flistinfo%
2Fgromacs.org_gmx-developers&amp;data=02%7C01%7Ckevin.boyd%40uconn.edu%
7C284e0eef573d4fbbbe3208d5f6c01641%7C17f1a87e2a254eaab9df9d439034
b080%7C0%7C1%7C636686227234582310&amp;sdata=50%2FxSFa9RwFqundMKoGlk%
2B2HoT0fVqf7JTLB7AX%2BNH4%3D&amp;reserved=0 or send a mail to
gmx-developers-request at gromacs.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20180731/d891b206/attachment.html>