[gmx-developers] gerrit submit on clean rebase without (re)verification

Mark Abraham mark.j.abraham at gmail.com
Tue Nov 21 23:23:54 CET 2017


IIRC there's a gerrit option that determines whether a no-conflict rebase
requires a verification vote (which we implement with Jenkins). I don't
know of a way to run the Jenkins pre-submit matrix after the submission of
such a patch, and not on a patch that didn't need a rebase (which would be
wasteful). So the options are to always require a verification (which will
slow things down for those who are active in coordinating submitting
patches, and those who are waiting for verifications), or to continue to
accept that life is sometimes messy and a master branch HEAD that fails to
pass Jenkins every few hundred patches or so is pretty good, really.


On Tue, Nov 21, 2017 at 9:11 PM Szilárd Páll <pall.szilard at gmail.com> wrote:

> Hi,
> Could we tweak the gerrit config to redo the pre-submit verification upon
> clear rebase prior to submission? I understand that we chose to take the
> moderate risk of ending up with broken verification (as clean rebase =/=>
> +2 verify), but we should at least try to rerun the pre-submit tests and
> post its results after the fact.
> It would not eliminate false positive -2 Verifie's, but would at least
> help avoiding confusion.
> Concrete case (I think) which luckily did get caught in post-submit:
> https://gerrit.gromacs.org/#/c/7174/
> http://jenkins.gromacs.org/view/Post-submit/job/Gromacs_PostSubmit_master/334/
> Cheers,
> --
> Szilárd
> --
> Gromacs Developers mailing list
> * Please search the archive at
> http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before
> posting!
> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
> * For (un)subscribe requests visit
> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers
> or send a mail to gmx-developers-request at gromacs.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://maillist.sys.kth.se/pipermail/gromacs.org_gmx-developers/attachments/20171121/277fb81d/attachment.html>

More information about the gromacs.org_gmx-developers mailing list