[gmx-developers] Reminder to fix final commit messages in Gitlab
Eric Irrgang
ericirrgang at gmail.com
Mon Oct 19 12:38:35 CEST 2020
It seems like there may be some inconsistent documentation out there, or maybe our version doesn't match that doc. https://gitlab.com/gitlab-org/gitlab/-/issues/26748#note_431644549 indicates there was a quiet logic change to use the _biggest_ commit message instead of the _first_ (multi-line) commit message, and it is creating quite a stir.
So one additional behavior developers can adopt to mitigate the problem Paul points out: make fix-up commit messages small. (If the gist of the MR has changed dramatically from the initial push, Paul's advice is probably good anyway!)
> On Oct 13, 2020, at 2:43 PM, Berk Hess <hess at kth.se> wrote:
>
> Hi,
>
> Their documentation on https://docs.gitlab.com/ee/user/project/merge_requests/squash_and_merge.html still says:
> The squashed commit’s commit message will be either:
>
> • Taken from the first multi-line commit message in the merge.
> • The merge request’s title if no multi-line commit message is found.
>
>
> I noticed an option appearing now to change the commit message. That is new so something has changed.
>
> Cheers,
>
> Berk
>
>
> On 13/10/2020 14.41, Paul bauer wrote:
>> Hello @ all gmx developers
>>
>> it seems that Gitlab changed the policy again for picking commit messages for squashed commits, with the latest message being picked now.
>>
>> I want to remind you to please fix the final commit message, because we are having a large number of misleading commit messages in the tree now.
>> I hope this will not change again without any notice in the future.
>>
>> Cheers
>>
>> Paul
>>
>
> --
> Gromacs Developers mailing list
>
> * Please search the archive at http://www.gromacs.org/Support/Mailing_Lists/GMX-developers_List before posting!
>
> * Can't post? Read http://www.gromacs.org/Support/Mailing_Lists
>
> * For (un)subscribe requests visit
> https://maillist.sys.kth.se/mailman/listinfo/gromacs.org_gmx-developers or send a mail to gmx-developers-request at gromacs.org.
More information about the gromacs.org_gmx-developers
mailing list